fix small data erroring out on mutual info score for error analysis guidance #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
gaugup,
RubyZ10,
vinuthakaranth,
tongyu-microsoft,
xuke444 and
hawestra
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1907 +/- ##
=======================================
Coverage 93.31% 93.32%
=======================================
Files 93 93
Lines 4578 4582 +4
=======================================
+ Hits 4272 4276 +4
Misses 306 306
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
imatiach-msft
force-pushed
the
ilmat/fix-ea-mutual-inf-sm-data-err
branch
from
a75a59f to
83ac0e3
Compare
imatiach-msft
force-pushed
the
ilmat/fix-ea-mutual-inf-sm-data-err
branch
from
83ac0e3 to
606c025
Compare
2 similar comments
vinuthakaranth
approved these changes
Jan 14, 2023
gaugup
approved these changes
Jan 14, 2023
This was referenced Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With a recent update in scikit-learn some tests started failing that used 3 rows of data when calculating mutual information score for the feature guidance score in the error analysis features list.
Since the dashboard is useful even when evaluating for a few instances, this PR resolved the exceptions by still calculating the score, either by replicate the row for n=1 or setting a lower number of nearest neighbors for KNN used by mutual information.
Checklist