-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test_data
to ICounterfactualData
#1892
Conversation
Signed-off-by: Gaurav Gupta <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1892 +/- ##
=======================================
Coverage 93.35% 93.35%
=======================================
Files 93 93
Lines 4574 4574
=======================================
Hits 4270 4270
Misses 304 304
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
What exactly is |
For large data scenario, not all the test samples will be present in UI. For local counterfactuals we would need to respond with the test dataset row. The size of the test data is not a concern as there is only one point returned for local counterfactuals. For initial run of rai, we limit the number of test samples to 5k. Please bear in mind that the generated counterfactuals per point determine the size of the output and not the test data itself. We discovered this late for local counterfactual work that @vinuthakaranth is driving. The design doc for large is already shared with the PM and dev teams to refer to. |
Description
Add
test_data
toICounterfactualData
so that UI can make use of the test_data returned by SDK backend for counterfactual table. This is related to the PR:- #1885.Checklist