Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Big data] Counterfactuals - part 1 #1888

Merged
merged 9 commits into from
Jan 7, 2023

Conversation

vinuthakaranth
Copy link
Contributor

Signed-off-by: vinutha karanth [email protected]

Description

This PR contains all the other changes needed for counterfactuals other than changes in libs/counterfactuals folder.
Next part will contain all changes in libs/counterfactuals folder.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: vinutha karanth <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #1888 (98ee8a9) into main (d02d2cb) will increase coverage by 0.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1888      +/-   ##
==========================================
+ Coverage   92.44%   93.35%   +0.90%     
==========================================
  Files         103       93      -10     
  Lines        4830     4572     -258     
==========================================
- Hits         4465     4268     -197     
+ Misses        365      304      -61     
Flag Coverage Δ
unittests 93.35% <ø> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rai_core_flask/rai_core_flask/flask_helper.py
..._flask/environments/credentialed_vm_environment.py
..._core_flask/environments/databricks_environment.py
...sk/rai_core_flask/environments/base_environment.py
...core_flask/rai_core_flask/environments/__init__.py
...i_core_flask/environments/public_vm_environment.py
...ai_core_flask/environments/azure_nb_environment.py
..._core_flask/rai_core_flask/environment_detector.py
...re_flask/environments/local_ipython_environment.py
rai_core_flask/rai_core_flask/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

1 similar comment
Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth vinuthakaranth enabled auto-merge (squash) January 6, 2023 20:09
1 similar comment
Copy link
Contributor

@gaugup gaugup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have one question in the PR if you could help clarify/

@vinuthakaranth vinuthakaranth merged commit e914062 into main Jan 7, 2023
@vinuthakaranth vinuthakaranth deleted the vikarant/bigdataCounterfactualsPart1 branch January 7, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants