Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out rai_core_flask CI and add paths filter #1884

Merged
merged 4 commits into from
Jan 6, 2023

Conversation

romanlutz
Copy link
Contributor

Description

With this change the rai_core_flask CI will only run if we make changes to that folder which is very rare. This should reduce the ridiculous amount of requeuing pipelines significantly.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Copy link
Contributor

@gaugup gaugup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the setting of fail_fast flag as well? I don't think we should run tests that will fail anyways.

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #1884 (4a63f93) into main (f2cdec6) will decrease coverage by 3.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1884      +/-   ##
==========================================
- Coverage   93.33%   90.10%   -3.23%     
==========================================
  Files          93      112      +19     
  Lines        4559     5883    +1324     
==========================================
+ Hits         4255     5301    +1046     
- Misses        304      582     +278     
Flag Coverage Δ
unittests 90.10% <ø> (-3.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raiwidgets/raiwidgets/model_analysis_dashboard.py 100.00% <0.00%> (ø)
...iwidgets/raiwidgets/fairness_metric_calculation.py 73.25% <0.00%> (ø)
...dgets/raiwidgets/error_analysis_dashboard_input.py 66.09% <0.00%> (ø)
raiwidgets/raiwidgets/__version__.py 100.00% <0.00%> (ø)
...iwidgets/raiwidgets/model_performance_dashboard.py 50.00% <0.00%> (ø)
raiwidgets/raiwidgets/interfaces.py 100.00% <0.00%> (ø)
raiwidgets/raiwidgets/fairness_dashboard.py 19.56% <0.00%> (ø)
...idgets/raiwidgets/responsibleai_dashboard_input.py 91.50% <0.00%> (ø)
raiwidgets/raiwidgets/cohort.py 95.00% <0.00%> (ø)
...iwidgets/raiwidgets/explanation_dashboard_input.py 59.85% <0.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@romanlutz romanlutz enabled auto-merge (squash) January 6, 2023 02:08
@romanlutz romanlutz disabled auto-merge January 6, 2023 05:13
@romanlutz romanlutz merged commit 64bb016 into main Jan 6, 2023
@romanlutz romanlutz deleted the romanlutz/restrict_flask_to_path branch January 6, 2023 05:15
@romanlutz
Copy link
Contributor Author

This only touches the CI python pipelines which are passing. Everything else looks to be passing, too, but I'd have to rerun them now again since another PR got merged. Since I've spent way too much time on rerunning builds today (and waiting for this to merge so that at least the other 5 PRs can run their builds somewhat faster) I'll make an exception and merge this by bypassing branch protections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants