-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate out rai_core_flask CI and add paths filter #1884
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the setting of fail_fast flag as well? I don't think we should run tests that will fail anyways.
Codecov Report
@@ Coverage Diff @@
## main #1884 +/- ##
==========================================
- Coverage 93.33% 90.10% -3.23%
==========================================
Files 93 112 +19
Lines 4559 5883 +1324
==========================================
+ Hits 4255 5301 +1046
- Misses 304 582 +278
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This only touches the CI python pipelines which are passing. Everything else looks to be passing, too, but I'd have to rerun them now again since another PR got merged. Since I've spent way too much time on rerunning builds today (and waiting for this to merge so that at least the other 5 PRs can run their builds somewhat faster) I'll make an exception and merge this by bypassing branch protections. |
Description
With this change the rai_core_flask CI will only run if we make changes to that folder which is very rare. This should reduce the ridiculous amount of requeuing pipelines significantly.
Checklist