Improve spacing in RAI dashboard #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
requested review from
xuke444,
tongyu-microsoft,
vinuthakaranth,
RubyZ10 and
hawestra
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1875 +/- ##
==========================================
- Coverage 92.44% 90.12% -2.32%
==========================================
Files 103 112 +9
Lines 4830 5896 +1066
==========================================
+ Hits 4465 5314 +849
- Misses 365 582 +217
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1 similar comment
|
Changed to 32px after discussing with Owen who approves of the change. Screenshots above not updated to reflect 32px, but it looks almost the same (just with 8px less, so slightly less padding) |
gaugup
approved these changes
Jan 5, 2023
|
Do other components like EA, explanations and causal also need this change? |
gaugup
reviewed
Jan 5, 2023
libs/dataset-explorer/src/lib/ChartView/utils/DatasetExplorerTab.styles.ts
Show resolved
Hide resolved
hawestra
approved these changes
Jan 5, 2023
1 similar comment
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is hopefully a visual improvement. I've added some additional padding in some of our components since several of them were really close to the boundary at the bottom. Before/after screenshots below:
Checklist