Remove setState call from render function in ProbabilityDistributionChart.tsx

[gaugup]

Description

Looks like we shouldn't explicitly setState in render function as per https://blog.logrocket.com/using-setstate-react-components/#:~:text=The%20render()%20function%20should,avoid%20using%20setState()%20here. So removing the call setState(). Looks like componentDidMount takes care of setting the state correctly anyways.

This helps in resolving the following warning trace seen in browser dev tools:-

Checklist

• I have added screenshots above for all UI changes.
• I have added e2e tests for all UI changes.
• Documentation was updated if it was needed.

[codecov-commenter]

Codecov Report

Merging #1858 (fc2b8ba) into main (d9821c4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1858   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files          93       93           
  Lines        4574     4574           
=======================================
  Hits         4270     4270           
  Misses        304      304           

Flag	Coverage Δ
unittests	93.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[github-actions]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/RemoveStateChangeInRender/dashboard/index.html

[romanlutz]

This should be fine. I remember putting this there because we don't have the probability options on first render pre-setup of the context, joint dataset etc. This should still work as it rerenders as soon as the context is there. Perhaps it makes sense to combine with the other if right before, or maybe that's obsolete now? I think it was just precondition for this if (since you need the probability options for that setState call that's removed in this PR).

[gaugup]

This should be fine. I remember putting this there because we don't have the probability options on first render pre-setup of the context, joint dataset etc. This should still work as it rerenders as soon as the context is there. Perhaps it makes sense to combine with the other if right before, or maybe that's obsolete now? I think it was just precondition for this if (since you need the probability options for that setState call that's removed in this PR).

The render should be called again if the componentDidMount causes a state change which it should. That should set the state probabilityOption properly.

Ideally 'this.getProbabilityOptions()' should be cached in the state in the constructor and reused. Doesn't look like it will change in the lifecycle of this component. This should simplify the code further. But as you said that it depends on jointdataset and the context to be correctly setup.

[github-actions]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/RemoveStateChangeInRender/dashboard/index.html

[github-actions]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/RemoveStateChangeInRender/dashboard/index.html