Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Big data] Counterfactuals - Part2 #1832

Merged
merged 52 commits into from
Jan 12, 2023
Merged

[Big data] Counterfactuals - Part2 #1832

merged 52 commits into from
Jan 12, 2023

Conversation

vinuthakaranth
Copy link
Contributor

@vinuthakaranth vinuthakaranth commented Dec 7, 2022 •
edited
Loading

Description

For large data, initial counterfactual chart will be bubble chart and on clicking on a bubble, scatter plot will be rendered.
On clicking on scatter plot point, workflow will be same as current experience.

Small data:
counterfactualsOriginalExp

Large Data:

counterfactualsBubChart3

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@vinuthakaranth
bub ch
5550302 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
5e2ad29 
…olbox into vikarant/bigdataBub

Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
a00953a 
…olbox into vikarant/bigdataBub
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
1cf172c 
…olbox into vikarant/bigdataBub
@vinuthakaranth
update
0a707f2 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
root dep
cfaff8f 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
update
d74e734 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
14dc2bd 
…olbox into vikarant/bigdataBub

Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
b712f0f 
…olbox into vikarant/bigdataBub
@vinuthakaranth
localcounter code
4cb719c 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
update interface
a19a45d 
Signed-off-by: vinutha karanth <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2022 •
edited
Loading

Codecov Report

Merging #1832 (73eaadd) into main (902a4ac) will not change coverage.
The diff coverage is n/a.

❗ Current head 73eaadd differs from pull request most recent head 74225b9. Consider uploading reports for the commit 74225b9 to get more accurate results

@@           Coverage Diff           @@
##             main    #1832   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files          93       93           
  Lines        4574     4574           
=======================================
  Hits         4270     4270           
  Misses        304      304
Flag Coverage Δ
unittests 93.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/bigdataBub/dashboard/index.html

@vinuthakaranth
local count
ed2c5ee 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
update local imp chart marker
00c855e 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
allowtreatascat
25cdeef 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
add few changes
cfe0abd 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
enus change
2c22420 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
394765e 
…olbox into vikarant/bigdataBub

Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
custom points updates
1af0837 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
custom point abs index changes
869e274 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
make local imp call async
4c55ff5 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
25f7a31 
…olbox into vikarant/bigdataBub
@vinuthakaranth
update
9f6602f 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
enus change
a890f19 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
create new comp for large counter data
5b18bdf 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
add loading for bubble
8e2a220 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
loading update for local imp
4c46914 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
rem unwanted code in largecc
0c9d3c1 
Signed-off-by: vinutha karanth <[email protected]>
@vinuthakaranth
remove console log
4dbf3b9 
Signed-off-by: vinutha karanth <[email protected]>
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/bigdataBub/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/bigdataBub/dashboard/index.html

@vinuthakaranth vinuthakaranth enabled auto-merge (squash) January 12, 2023 17:50
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/bigdataBub/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/bigdataBub/dashboard/index.html

@vinuthakaranth vinuthakaranth merged commit 03603cd into main Jan 12, 2023
@vinuthakaranth vinuthakaranth deleted the vikarant/bigdataBub branch January 12, 2023 21:18
@imatiach-msft imatiach-msft mentioned this pull request Jan 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanlutz romanlutz romanlutz left review comments

@gaugup gaugup gaugup left review comments

@tongyu-microsoft tongyu-microsoft tongyu-microsoft approved these changes

@imatiach-msft imatiach-msft Awaiting requested review from imatiach-msft imatiach-msft is a code owner

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@RubyZ10 RubyZ10 Awaiting requested review from RubyZ10 RubyZ10 is a code owner

@hawestra hawestra Awaiting requested review from hawestra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vinuthakaranth @codecov-commenter @romanlutz @gaugup @tongyu-microsoft