Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused flight "newSdkEndpoints" #1831

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Dec 5, 2022

Description

It seems this is not being used anywhere.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022

Codecov Report

Merging #1831 (d3b9dcc) into main (752c2d0) will decrease coverage by 1.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1831      +/-   ##
==========================================
- Coverage   88.54%   87.33%   -1.22%     
==========================================
  Files          96       39      -57     
  Lines        5490     1792    -3698     
==========================================
- Hits         4861     1565    -3296     
+ Misses        629      227     -402     
Flag Coverage Δ
unittests 87.33% <ø> (-1.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
responsibleai/responsibleai/exceptions.py
raiwidgets/raiwidgets/error_analysis_constants.py
...nsibleai/databalanceanalysis/data_balance_utils.py
...ponsibleai/responsibleai/_tools/shared/__init__.py
...leai/responsibleai/modelanalysis/model_analysis.py
...i/responsibleai/managers/counterfactual_manager.py
responsibleai/responsibleai/_config/base_config.py
raiwidgets/raiwidgets/error_analysis_dashboard.py
...i/responsibleai/managers/error_analysis_manager.py
...tools/error_analysis/dashboard_schemas/__init__.py
... and 47 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you, but if you're planning to add it back in a few weeks then you can also keep it around

@gaugup gaugup enabled auto-merge (squash) December 6, 2022 02:08
@gaugup gaugup merged commit c1bcfdc into main Dec 6, 2022
@gaugup gaugup deleted the gagup/RemoveNewSdkEndpointsFlight branch December 6, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants