Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fast pass accessibility bugs #1817

Merged
merged 6 commits into from
Nov 21, 2022
Merged

Conversation

vinuthakaranth
Copy link
Contributor

Description

Fix fast pass accessibility bugs

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: vinutha karanth <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Merging #1817 (96e48f6) into main (c1e8fdb) will increase coverage by 10.53%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1817       +/-   ##
===========================================
+ Coverage   77.98%   88.52%   +10.53%     
===========================================
  Files          24       96       +72     
  Lines        1281     5472     +4191     
===========================================
+ Hits          999     4844     +3845     
- Misses        282      628      +346     
Flag Coverage Δ
unittests 88.52% <ø> (+10.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...i_core_flask/environments/public_vm_environment.py 88.88% <0.00%> (ø)
...tools/error_analysis/dashboard_schemas/__init__.py 100.00% <0.00%> (ø)
...ibleai/responsibleai/managers/explainer_manager.py 89.55% <0.00%> (ø)
...leai/responsibleai/modelanalysis/model_analysis.py 94.33% <0.00%> (ø)
...is/erroranalysis/_internal/surrogate_error_tree.py 87.85% <0.00%> (ø)
...ranalysis/erroranalysis/analyzer/error_analyzer.py 95.18% <0.00%> (ø)
...ai/databalanceanalysis/feature_balance_measures.py 100.00% <0.00%> (ø)
responsibleai/responsibleai/_data_validations.py 94.73% <0.00%> (ø)
...tabalanceanalysis/distribution_balance_measures.py 100.00% <0.00%> (ø)
...s/erroranalysis/_internal/error_report/__init__.py 100.00% <0.00%> (ø)
... and 62 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vinuthakaranth vinuthakaranth enabled auto-merge (squash) November 18, 2022 19:24
@vinuthakaranth vinuthakaranth merged commit 2ce33b6 into main Nov 21, 2022
@vinuthakaranth vinuthakaranth deleted the vikarant/accessibilityrembugs branch November 21, 2022 07:28
gaugup pushed a commit that referenced this pull request Nov 21, 2022
* fast pass fix

Signed-off-by: vinutha karanth <[email protected]>

* lintfix

Signed-off-by: vinutha karanth <[email protected]>

* aria fix

Signed-off-by: vinutha karanth <[email protected]>

Signed-off-by: vinutha karanth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants