Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest 16.x node version for tests #1809

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Nov 9, 2022

Description

We previously capped node version to 16.8 due to build failures. This PR tries to update to latest again, as it was before.

I also tried to add 18.x as well, but I saw build failures so I took it out (related to rollup plugin which I think just needs to be upgraded, but when I upgraded I saw some other failures). Now that 18.x has an LTS version released we should at some point look into adding it as well.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@imatiach-msft imatiach-msft force-pushed the ilmat/update-node-vers branch from 01312f0 to 2b011a6 Compare November 9, 2022 16:40
Copy link
Contributor

@gaugup gaugup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go into postga as main is locked right now?

@imatiach-msft imatiach-msft force-pushed the ilmat/update-node-vers branch from 2b011a6 to 08b0733 Compare November 9, 2022 16:48
2 similar comments
@imatiach-msft
Copy link
Contributor Author

@gaugup I think we can just wait until we've lifted our internal code freeze

@imatiach-msft imatiach-msft changed the title update to latest 16.x node version for tests and add 18.x LTS to typescript tests update to latest 16.x node version for tests Nov 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Merging #1809 (7656ce9) into main (d6cff71) will increase coverage by 12.81%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1809       +/-   ##
===========================================
+ Coverage   75.72%   88.53%   +12.81%     
===========================================
  Files          16       96       +80     
  Lines        1141     5479     +4338     
===========================================
+ Hits          864     4851     +3987     
- Misses        277      628      +351     
Flag Coverage Δ
unittests 88.53% <ø> (+12.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raiutils/raiutils/dataset/dataset.py 100.00% <0.00%> (ø)
rai_test_utils/rai_test_utils/datasets/__init__.py 100.00% <0.00%> (ø)
...leai/responsibleai/modelanalysis/model_analysis.py 94.33% <0.00%> (ø)
...tabalanceanalysis/distribution_balance_measures.py 100.00% <0.00%> (ø)
...erroranalysis/_internal/error_analyzer/__init__.py 100.00% <0.00%> (ø)
...is/erroranalysis/_internal/process_categoricals.py 100.00% <0.00%> (ø)
...onsibleai/responsibleai/serialization_utilities.py 96.55% <0.00%> (ø)
erroranalysis/erroranalysis/analyzer/__init__.py 100.00% <0.00%> (ø)
..._core_flask/rai_core_flask/environment_detector.py 53.33% <0.00%> (ø)
...bleai/responsibleai/_tools/causal/causal_result.py 97.05% <0.00%> (ø)
... and 70 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imatiach-msft imatiach-msft merged commit 0582d0f into main Nov 29, 2022
@imatiach-msft imatiach-msft deleted the ilmat/update-node-vers branch November 29, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants