-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to latest 16.x node version for tests #1809
Conversation
01312f0
to
2b011a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this go into postga as main is locked right now?
2b011a6
to
08b0733
Compare
2 similar comments
@gaugup I think we can just wait until we've lifted our internal code freeze |
08b0733
to
e76787a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1809 +/- ##
===========================================
+ Coverage 75.72% 88.53% +12.81%
===========================================
Files 16 96 +80
Lines 1141 5479 +4338
===========================================
+ Hits 864 4851 +3987
- Misses 277 628 +351
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
e76787a
to
7656ce9
Compare
Description
We previously capped node version to 16.8 due to build failures. This PR tries to update to latest again, as it was before.
I also tried to add 18.x as well, but I saw build failures so I took it out (related to rollup plugin which I think just needs to be upgraded, but when I upgraded I saw some other failures). Now that 18.x has an LTS version released we should at some point look into adding it as well.
Checklist