Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate debug_ml and matrix endpoints to compute_error_tree_on_dataset() and compute_matrix_on_dataset() #1795

Merged
merged 20 commits into from
Nov 29, 2022
Merged

Migrate debug_ml and matrix endpoints to compute_error_tree_on_dataset() and compute_matrix_on_dataset() #1795

merged 20 commits into from
Nov 29, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Oct 28, 2022 •
edited
Loading

Description

Migrate debug_ml and matrix endpoints to compute_error_tree_on_dataset() and compute_matrix_on_dataset()

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

gaugup and others added 17 commits September 29, 2022 16:27
@gaugup
Add postga build trigger (#1755) (#1756)
6f16591 
Signed-off-by: Gaurav Gupta <[email protected]>

Signed-off-by: Gaurav Gupta <[email protected]>

Signed-off-by: Gaurav Gupta <[email protected]>
@gaugup
Merge branch 'main' into postga
a54a531
@gaugup
Add model wrapper for wrapping predictions and test data (#1762)
7bb4087 
* Add model wrapper for wrapping predictions and test data

Signed-off-by: Gaurav Gupta <[email protected]>

* Fix failing tests

Signed-off-by: Gaurav Gupta <[email protected]>

Signed-off-by: Gaurav Gupta <[email protected]>
@gaugup
Merge branch 'main' into postga
8395b89
@gaugup
Merge branch 'main' into postga
c400c30
@gaugup
Change description of cohort selection panel in Aggregate Feature Imp…
d0d338e 
…ortance (#1770)

Signed-off-by: Gaurav Gupta <[email protected]>

Signed-off-by: Gaurav Gupta <[email protected]>
@gaugup
Support cohort filtering of string target in rai_insights (#1771)
18af5ab 
* Port tests

Signed-off-by: Gaurav Gupta <[email protected]>

* Fix rai_insights

Signed-off-by: Gaurav Gupta <[email protected]>

Signed-off-by: Gaurav Gupta <[email protected]>
@gaugup
Simplify tests in test_cohort_filter.py (#1772)
c23be59 
* Simply tests in test_cohort_filter.py

Signed-off-by: Gaurav Gupta <[email protected]>

* Change test name

Signed-off-by: Gaurav Gupta <[email protected]>

Signed-off-by: Gaurav Gupta <[email protected]>
@gaugup
Move cohort re-labelling logic to Cohort.ts (#1773)
27fb668 
* Move cohort re-labelling logic to Cohort.ts

Signed-off-by: Gaurav Gupta <[email protected]>

* Lint fix

Signed-off-by: Gaurav Gupta <[email protected]>

* Lint fix

Signed-off-by: Gaurav Gupta <[email protected]>

Signed-off-by: Gaurav Gupta <[email protected]>
@gaugup
Update requirements.txt (#1779)
5609f3a
@gaugup
Refactor DataAnalysisTab into Chartview/DataAnalysisView and DataBala…
68e1e2a 
…nceView (#1775)

* Refactor DataAnalysisTab into Chartview/DataAnalysisView and DataBalanceView

Signed-off-by: Gaurav Gupta <[email protected]>

* Fix lint

Signed-off-by: Gaurav Gupta <[email protected]>

Signed-off-by: Gaurav Gupta <[email protected]>
@tongyu-microsoft
[Highcharts] Enable csv download, xls download and view data table in…
a5ecb69 
… highcharts (#1783)

* enable csv xls download in hightcharts

* localization
@gaugup
Merge branch 'main' into postga
e046f08
@gaugup
Merge branch 'main' into postga
5f0d1c8
@gaugup
Add new data APIs for compute_matrix() and compute_error_tree() (#1790)
0a45019 
Signed-off-by: Gaurav Gupta <[email protected]>

Signed-off-by: Gaurav Gupta <[email protected]>
@tongyu-microsoft @gaugup
update e2e visit function (#1792)
2183db1
@gaugup
Migrate debug_ml and matrix endpoints to compute_error_tree_on_datase…
cc1efaa 
…t() and compute_matrix_on_dataset()

Signed-off-by: Gaurav Gupta <[email protected]>
@gaugup gaugup changed the base branch from postga to main October 28, 2022 18:25
@gaugup gaugup requested a review from kicha0 as a code owner October 28, 2022 18:25
@gaugup gaugup changed the base branch from main to postga October 28, 2022 18:26
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022 •
edited
Loading

Codecov Report

Merging #1795 (b41fb0e) into main (0582d0f) will decrease coverage by 5.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1795      +/-   ##
==========================================
- Coverage   88.53%   83.37%   -5.17%     
==========================================
  Files          96       38      -58     
  Lines        5479     2653    -2826     
==========================================
- Hits         4851     2212    -2639     
+ Misses        628      441     -187
Flag Coverage Δ
unittests 83.37% <100.00%> (-5.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...idgets/raiwidgets/responsibleai_dashboard_input.py 91.44% <100.00%> (+0.11%) ⬆️
raiutils/raiutils/common/retries.py
raiutils/raiutils/webservice/webservice.py
...i/responsibleai/managers/error_analysis_manager.py
...sibleai/responsibleai/rai_insights/rai_insights.py
responsibleai/responsibleai/managers/__init__.py
...tools/error_analysis/dashboard_schemas/__init__.py
...ai/responsibleai/_tools/error_analysis/__init__.py
...ai/responsibleai/rai_insights/rai_base_insights.py
..._utils/rai_test_utils/datasets/tabular/__init__.py
... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup requested a review from hawestra as a code owner November 22, 2022 15:53
@gaugup gaugup changed the base branch from postga to main November 22, 2022 15:55
@gaugup gaugup changed the title [Do not merge] Migrate debug_ml and matrix endpoints to compute_error_tree_on_dataset() and compute_matrix_on_dataset() Migrate debug_ml and matrix endpoints to compute_error_tree_on_dataset() and compute_matrix_on_dataset() Nov 29, 2022
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/MigrateEAEndPoints/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/MigrateEAEndPoints/dashboard/index.html

@gaugup gaugup enabled auto-merge (squash) November 29, 2022 21:25
@gaugup gaugup merged commit 5fe8a91 into main Nov 29, 2022
@gaugup gaugup deleted the gaugup/MigrateEAEndPoints branch November 29, 2022 21:40
@imatiach-msft imatiach-msft mentioned this pull request Jan 6, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinuthakaranth vinuthakaranth vinuthakaranth approved these changes

@imatiach-msft imatiach-msft Awaiting requested review from imatiach-msft imatiach-msft is a code owner

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@romanlutz romanlutz Awaiting requested review from romanlutz

@RubyZ10 RubyZ10 Awaiting requested review from RubyZ10 RubyZ10 is a code owner

@tongyu-microsoft tongyu-microsoft Awaiting requested review from tongyu-microsoft

@kicha0 kicha0 Awaiting requested review from kicha0

@hawestra hawestra Awaiting requested review from hawestra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaugup @codecov-commenter @vinuthakaranth @tongyu-microsoft