Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency plot showing Average of abs value #1765

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

vinuthakaranth
Copy link
Contributor

@vinuthakaranth vinuthakaranth commented Oct 5, 2022

Signed-off-by: vinutha karanth [email protected]

Description

we initialize with 'Average of absolute value' and corresponding data is shown in plot but just the dropdown doesn't show the above option.
One of the way to fix is to show 'Average of absolute value' as one of the drop down option as below along with other options.
Reviewed by Mehrnoosh.

depPlotAvgAbs

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: vinutha karanth <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #1765 (ef77890) into main (c044957) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1765   +/-   ##
=======================================
  Coverage   88.30%   88.30%           
=======================================
  Files          89       89           
  Lines        5250     5250           
=======================================
  Hits         4636     4636           
  Misses        614      614           
Flag Coverage Δ
unittests 88.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vinuthakaranth vinuthakaranth marked this pull request as ready for review October 5, 2022 21:58
@gaugup
Copy link
Contributor

gaugup commented Oct 5, 2022

Is there an E2E test for this which can validate this scenario?

@vinuthakaranth vinuthakaranth enabled auto-merge (squash) October 6, 2022 17:19
@vinuthakaranth
Copy link
Contributor Author

Is there an E2E test for this which can validate this scenario?
I am planning to add it in coming PR. Just wanted to merge this for GA.

@vinuthakaranth vinuthakaranth merged commit 3677a0b into main Oct 7, 2022
@vinuthakaranth vinuthakaranth deleted the vikarant/depPlotFix branch October 7, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants