Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flake8 to 4.0.1 in requirements-linting.txt to fix failing linting build #1760

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Oct 3, 2022

Description

It seems the linting build is failing with the following error:-

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.7.14/x64/bin/flake[8](https://github.com/microsoft/responsible-ai-toolbox/actions/runs/3175056318/jobs/5172629653#step:5:9)", line 8, in <module>
    sys.exit(main())
  File "/opt/hostedtoolcache/Python/3.7.[14](https://github.com/microsoft/responsible-ai-toolbox/actions/runs/3175056318/jobs/5172629653#step:5:15)/x64/lib/python3.7/site-packages/flake8/main/cli.py", line 22, in main
    app.run(argv)
  File "/opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/site-packages/flake8/main/application.py", line 363, in run
    self._run(argv)
  File "/opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/site-packages/flake8/main/application.py", line 350, in _run
    self.initialize(argv)
  File "/opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/site-packages/flake8/main/application.py", line 330, in initialize
    self.find_plugins(config_finder)
  File "/opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/site-packages/flake8/main/application.py", line [15](https://github.com/microsoft/responsible-ai-toolbox/actions/runs/3175056318/jobs/5172629653#step:5:16)3, in find_plugins
    self.check_plugins = plugin_manager.Checkers(local_plugins.extension)
  File "/opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/site-packages/flake8/plugins/manager.py", line 357, in __init__
    self.namespace, local_plugins=local_plugins
  File "/opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/site-packages/flake8/plugins/manager.py", line [23](https://github.com/microsoft/responsible-ai-toolbox/actions/runs/3175056318/jobs/5172629653#step:5:24)8, in __init__
    self._load_entrypoint_plugins()
  File "/opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/site-packages/flake8/plugins/manager.py", line [25](https://github.com/microsoft/responsible-ai-toolbox/actions/runs/3175056318/jobs/5172629653#step:5:26)4, in _load_entrypoint_plugins
    eps = importlib_metadata.entry_points().get(self.namespace, ())
AttributeError: 'EntryPoints' object has no attribute 'get'
Error: Process completed with exit code 1.

Pinning flake8 to 4.0.1 fixes this error.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@gaugup gaugup changed the title [WIP] Update requirements-linting.txt Update flake8 to 4.0.1 in requirements-linting.txt to fix failing linting build Oct 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Merging #1760 (1fbb0eb) into main (f3fad40) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1760   +/-   ##
=======================================
  Coverage   88.30%   88.30%           
=======================================
  Files          89       89           
  Lines        5250     5250           
=======================================
  Hits         4636     4636           
  Misses        614      614           
Flag Coverage Δ
unittests 88.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup enabled auto-merge (squash) October 3, 2022 18:24
@gaugup gaugup merged commit cbb4289 into main Oct 3, 2022
@gaugup gaugup deleted the gaugup/FixLintingBuild branch October 3, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants