Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the unnecessary dependency pins in nlp-feature-extractors package #1759

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

imatiach-msft
Copy link
Contributor

Description

Remove the unnecessary dependency pins in nlp-feature-extractors package.
The pin on tqdm caused issues with other dependencies during image create, even though it is completely unnecessary (there is no specific API used which needs a particular version, it's using the most basic functionality to create the status bar). The pins are unnecessary and create a lot of dependency issues with other packages. Also removing protobuf as it's not needed at all anywhere.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@imatiach-msft imatiach-msft force-pushed the ilmat/rm-hard-pins-nlp branch from 01b9348 to 6bfcd9d Compare October 3, 2022 14:41
1 similar comment
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Merging #1759 (01b9348) into main (cbb4289) will increase coverage by 0.42%.
The diff coverage is n/a.

❗ Current head 01b9348 differs from pull request most recent head df6d26b. Consider uploading reports for the commit df6d26b to get more accurate results

@@            Coverage Diff             @@
##             main    #1759      +/-   ##
==========================================
+ Coverage   88.30%   88.72%   +0.42%     
==========================================
  Files          89       70      -19     
  Lines        5250     4844     -406     
==========================================
- Hits         4636     4298     -338     
+ Misses        614      546      -68     
Flag Coverage Δ
unittests 88.72% <ø> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rai_core_flask/rai_core_flask/flask_helper.py
..._flask/environments/credentialed_vm_environment.py
raiutils/raiutils/models/model_utils.py
..._core_flask/rai_core_flask/environment_detector.py
.../raiutils/data_processing/data_processing_utils.py
raiutils/raiutils/webservice/webservice.py
raiutils/raiutils/common/retries.py
raiutils/raiutils/models/__init__.py
...ai_core_flask/environments/azure_nb_environment.py
raiutils/raiutils/dataset/__init__.py
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imatiach-msft imatiach-msft force-pushed the ilmat/rm-hard-pins-nlp branch from 6bfcd9d to df6d26b Compare October 3, 2022 19:32
@imatiach-msft imatiach-msft merged commit 6accbfd into main Nov 28, 2022
@imatiach-msft imatiach-msft deleted the ilmat/rm-hard-pins-nlp branch November 28, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants