[A11y] 1. Hide chart heading & 2. Fix Add component callout high contrast focus indicator #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruby Zhu <[email protected]>
Signed-off-by: Ruby Zhu <[email protected]>
Signed-off-by: Ruby Zhu <[email protected]>
Signed-off-by: Ruby Zhu <[email protected]>
Signed-off-by: Ruby Zhu <[email protected]>
Signed-off-by: Ruby Zhu <[email protected]>
Signed-off-by: Ruby Zhu <[email protected]>
Signed-off-by: Ruby Zhu <[email protected]>
Signed-off-by: Ruby Zhu <[email protected]>
RubyZ10
requested review from
imatiach-msft,
tongyu-microsoft,
xuke444,
vinuthakaranth and
romanlutz
as code owners
RubyZ10
changed the title
tongyu-microsoft
approved these changes
Sep 30, 2022
imatiach-msft
approved these changes
Sep 30, 2022
gaugup
approved these changes
Sep 30, 2022
Codecov Report
@@ Coverage Diff @@
## main #1758 +/- ##
=======================================
Coverage 88.30% 88.30%
=======================================
Files 89 89
Lines 5250 5250
=======================================
Hits 4636 4636
Misses 614 614
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1. Hide chart heading tag
Highcharts has default heading for chart, for accessibility compliance, if headings should not be defined if it is not visible, override the default behavior by using highcharts accessibility API options "beforeChartFormat"
Before change
After change
2. Fix add component high contrast focus
Before change
Focus indicator is not properly visible
After change
Checklist