Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] announce the displayed search results information of Feature List "Search" edit field. #1757

Merged
merged 14 commits into from
Sep 30, 2022

Conversation

RubyZ10
Copy link
Contributor

@RubyZ10 RubyZ10 commented Sep 29, 2022

Description

announce the displayed search results information of Feature List "Search" edit field.
in below screen shots after user type in t, screen reader will read "results displayed out of 9 for t"
image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Merging #1757 (ab073c8) into main (bd6e510) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1757   +/-   ##
=======================================
  Coverage   88.30%   88.30%           
=======================================
  Files          89       89           
  Lines        5250     5250           
=======================================
  Hits         4636     4636           
  Misses        614      614           
Flag Coverage Δ
unittests 88.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

1 similar comment
@RubyZ10 RubyZ10 enabled auto-merge (squash) September 29, 2022 23:55
@RubyZ10 RubyZ10 merged commit 8f2f826 into main Sep 30, 2022
@RubyZ10 RubyZ10 deleted the zhenzhu/A11y0926 branch September 30, 2022 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants