Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in data characteristics of RAI vision dashboard, fix bug where labels to display is reset when changing number of rows #1748

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

imatiach-msft
Copy link
Contributor

Description

In data characteristics of RAI vision dashboard, fix bug where labels to display is reset when changing number of rows.

Repro steps:
image

select milk_bottle in the select labels to display combo box
change rows
the select labels to display comobox gets reset

New behavior: the labels to display does not get reset.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Merging #1748 (fb550e2) into main (fb550e2) will not change coverage.
The diff coverage is n/a.

❗ Current head fb550e2 differs from pull request most recent head 7d11e28. Consider uploading reports for the commit 7d11e28 to get more accurate results

@@           Coverage Diff           @@
##             main    #1748   +/-   ##
=======================================
  Coverage   88.30%   88.30%           
=======================================
  Files          90       90           
  Lines        5252     5252           
=======================================
  Hits         4638     4638           
  Misses        614      614           
Flag Coverage Δ
unittests 88.30% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

… to display is reset when changing number of rows
@imatiach-msft imatiach-msft merged commit 2050f20 into main Sep 27, 2022
@imatiach-msft imatiach-msft deleted the ilmat/change-num-rows branch September 27, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants