Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in error analysis, refactor error rate metric into function #1742

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

imatiach-msft
Copy link
Contributor

Description

In erroranalysis package, refactor the error rate metric computation into a function, to make it more similar to other metrics.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022

Codecov Report

Merging #1742 (d93ceb5) into main (6d46af4) will increase coverage by 0.00%.
The diff coverage is 84.61%.

@@           Coverage Diff           @@
##             main    #1742   +/-   ##
=======================================
  Coverage   88.54%   88.54%           
=======================================
  Files          96       96           
  Lines        5481     5490    +9     
=======================================
+ Hits         4853     4861    +8     
- Misses        628      629    +1     
Flag Coverage Δ
unittests 88.54% <84.61%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
erroranalysis/erroranalysis/_internal/metrics.py 88.67% <77.77%> (-2.23%) ⬇️
...is/erroranalysis/_internal/surrogate_error_tree.py 88.17% <100.00%> (+0.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imatiach-msft imatiach-msft force-pushed the ilmat/refactor-ea-err-metric branch from fb05415 to 813d7d5 Compare December 2, 2022 15:42
@imatiach-msft imatiach-msft force-pushed the ilmat/refactor-ea-err-metric branch from 813d7d5 to d93ceb5 Compare December 2, 2022 16:18
1 similar comment
@imatiach-msft imatiach-msft merged commit 46afc20 into main Dec 2, 2022
@imatiach-msft imatiach-msft deleted the ilmat/refactor-ea-err-metric branch December 2, 2022 19:53
@imatiach-msft imatiach-msft mentioned this pull request Jan 15, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants