[A11y] Fix table view keyboard access #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruby Zhu <[email protected]>
Signed-off-by: Ruby Zhu <[email protected]>
Signed-off-by: Ruby Zhu <[email protected]>
Signed-off-by: Ruby Zhu <[email protected]>
Signed-off-by: Ruby Zhu <[email protected]>
RubyZ10
requested review from
romanlutz,
xuke444,
tongyu-microsoft and
vinuthakaranth
as code owners
imatiach-msft
approved these changes
Sep 21, 2022
Codecov Report
@@ Coverage Diff @@
## main #1739 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 32 32
Lines 1626 1626
=======================================
Hits 1461 1461
Misses 165 165
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tongyu-microsoft
approved these changes
Sep 21, 2022
1 similar comment
vinuthakaranth
approved these changes
Sep 22, 2022
Signed-off-by: Ruby Zhu <[email protected]>
1 similar comment
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before change
group header is not keyboard accessible
view
View after change
view
Checklist