Fix cohort deletion not working #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: vinutha karanth <[email protected]>
…olbox into vikarant/cohortDeleteFIx
vinuthakaranth
requested review from
tongyu-microsoft,
romanlutz,
imatiach-msft,
RubyZ10 and
xuke444
as code owners
RubyZ10
approved these changes
Sep 21, 2022
imatiach-msft
approved these changes
Sep 21, 2022
libs/e2e/src/lib/describer/modelAssessment/dataExplorer/describeCohortFunctionality.ts
Show resolved
Hide resolved
tongyu-microsoft
approved these changes
Sep 21, 2022
gaugup
approved these changes
Sep 21, 2022
Signed-off-by: vinutha karanth <[email protected]>
…olbox into vikarant/cohortDeleteFIx
Codecov Report
@@ Coverage Diff @@
## main #1738 +/- ##
=======================================
Coverage 92.10% 92.10%
=======================================
Files 86 86
Lines 4268 4268
=======================================
Hits 3931 3931
Misses 337 337
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: vinutha karanth <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cohort deletion not working
Description
Since item key was passed as key prop, it was always undefined as React uses key as prop.
Checklist