in RAI text dashboard, fix topK and maxK on slidebar not updating when selecting different text documents #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
gaugup,
tongyu-microsoft,
xuke444,
RubyZ10 and
vinuthakaranth
as code owners
imatiach-msft
force-pushed
the
ilmat/fix-top-k
branch
from
ae9e699 to
b216ded
Compare
Codecov Report
@@ Coverage Diff @@
## main #1737 +/- ##
==========================================
+ Coverage 88.99% 92.10% +3.10%
==========================================
Files 105 86 -19
Lines 5589 4268 -1321
==========================================
- Hits 4974 3931 -1043
+ Misses 615 337 -278
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…n selecting different text documents
imatiach-msft
force-pushed
the
ilmat/fix-top-k
branch
from
b216ded to
b47115b
Compare
1 similar comment
xuke444
approved these changes
Sep 21, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In RAI text dashboard, the slidebar is currently not updating when selecting different instances correctly. We should recompute the current set value and the max value in the slidebar when the user selects different documents/instances. It is questionable though if we indeed want to "reset" the current topK value, as the user may want to keep the same number of top words when selecting different instances, but I think it is better to do this since the current value may not make sense when looking at documents that vary in # of words significantly. However for maxK parameter (the max number of words user can view in text highlighting component) we definitely should recompute this value and it is a clear bug not to do this.
Checklist