Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor vision dashboard to remove getDerivedStateFromProps #1732

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

imatiach-msft
Copy link
Contributor

Description

Refactor vision dashboard to remove getDerivedStateFromProps

This method is deprecated and should be removed.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Merging #1732 (c496d8a) into main (c496d8a) will not change coverage.
The diff coverage is n/a.

❗ Current head c496d8a differs from pull request most recent head 878c5c1. Consider uploading reports for the commit 878c5c1 to get more accurate results

@@           Coverage Diff           @@
##             main    #1732   +/-   ##
=======================================
  Coverage   89.01%   89.01%           
=======================================
  Files         105      105           
  Lines        5582     5582           
=======================================
  Hits         4969     4969           
  Misses        613      613           
Flag Coverage Δ
unittests 89.01% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imatiach-msft imatiach-msft merged commit c86bfff into main Sep 20, 2022
@imatiach-msft imatiach-msft deleted the ilmat/rm-get-der-state branch September 20, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants