Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix images in data characteristics panel hiding the success/failure instances #1731

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

imatiach-msft
Copy link
Contributor

Description

Fix the images in the data characteristics tab hiding the failure/success indicators (the blue/red boxes) for certain image dimensions.

Screenshot before the changes on the fridge dataset:

image

Screenshot after the changes on the fridge dataset:

image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-data-char-images branch from 12efc7a to 9e21363 Compare September 19, 2022 19:48
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Merging #1731 (12efc7a) into main (ac30fae) will not change coverage.
The diff coverage is n/a.

❗ Current head 12efc7a differs from pull request most recent head 9e21363. Consider uploading reports for the commit 9e21363 to get more accurate results

@@           Coverage Diff           @@
##             main    #1731   +/-   ##
=======================================
  Coverage   89.01%   89.01%           
=======================================
  Files         105      105           
  Lines        5582     5582           
=======================================
  Hits         4969     4969           
  Misses        613      613           
Flag Coverage Δ
unittests 89.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

1 similar comment
@imatiach-msft imatiach-msft merged commit c496d8a into main Sep 20, 2022
@imatiach-msft imatiach-msft deleted the ilmat/fix-data-char-images branch September 20, 2022 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants