Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'Error' filter name to 'Regression error' #1729

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Sep 17, 2022

Description

Rename 'Error' filter name to 'Regression error'. UI sends 'Regression error' to send SDK.

image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2022

Codecov Report

Merging #1729 (a724c5d) into main (db651db) will increase coverage by 1.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1729      +/-   ##
==========================================
+ Coverage   89.01%   90.39%   +1.37%     
==========================================
  Files         105       39      -66     
  Lines        5582     1718    -3864     
==========================================
- Hits         4969     1553    -3416     
+ Misses        613      165     -448     
Flag Coverage Δ
unittests 90.39% <100.00%> (+1.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ranalysis/erroranalysis/_internal/cohort_filter.py 87.17% <100.00%> (ø)
raiwidgets/raiwidgets/fairness_dashboard.py
...tools/error_analysis/dashboard_schemas/__init__.py
...sibleai/responsibleai/rai_insights/rai_insights.py
...leai/responsibleai/modelanalysis/model_analysis.py
...ponsibleai/responsibleai/_tools/causal/__init__.py
...ai/responsibleai/rai_insights/rai_base_insights.py
responsibleai/responsibleai/_config/base_config.py
...tools/counterfactual/dashboard_schemas/__init__.py
...dgets/raiwidgets/error_analysis_dashboard_input.py
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure, this doesn't break the UI in any way, as it looks like it might be a breaking change? As in the UI doesn't expect to see Error anywhere instead of Regression error in the result right now?

@gaugup gaugup enabled auto-merge (squash) September 19, 2022 19:16
@gaugup
Copy link
Contributor Author

gaugup commented Sep 19, 2022

Just to make sure, this doesn't break the UI in any way, as it looks like it might be a breaking change? As in the UI doesn't expect to see Error anywhere instead of Regression error in the result right now?

I thought that UI sends "Error" but it was not the case. So this was not working as expected previously. With this change it works now as expected. There is not breaking change on UI side.

@gaugup gaugup merged commit 6a6ebe6 into main Sep 19, 2022
@gaugup gaugup deleted the gaugup/CorrectRegressionErrorCohortFilter branch September 19, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants