-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename 'Error' filter name to 'Regression error' #1729
Conversation
Signed-off-by: Gaurav Gupta <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1729 +/- ##
==========================================
+ Coverage 89.01% 90.39% +1.37%
==========================================
Files 105 39 -66
Lines 5582 1718 -3864
==========================================
- Hits 4969 1553 -3416
+ Misses 613 165 -448
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure, this doesn't break the UI in any way, as it looks like it might be a breaking change? As in the UI doesn't expect to see Error anywhere instead of Regression error in the result right now?
I thought that UI sends "Error" but it was not the case. So this was not working as expected previously. With this change it works now as expected. There is not breaking change on UI side. |
Description
Rename 'Error' filter name to 'Regression error'. UI sends 'Regression error' to send SDK.
Checklist