Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollback local importance selection #1726

Merged
merged 3 commits into from
Sep 17, 2022
Merged

rollback local importance selection #1726

merged 3 commits into from
Sep 17, 2022

Conversation

xuke444
Copy link
Collaborator

@xuke444 xuke444 commented Sep 16, 2022

Signed-off-by: Ke Xu [email protected]

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Ke Xu <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2022

Codecov Report

Merging #1726 (fcd3673) into main (2bd09f9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1726   +/-   ##
=======================================
  Coverage   89.00%   89.00%           
=======================================
  Files         105      105           
  Lines        5577     5577           
=======================================
  Hits         4964     4964           
  Misses        613      613           
Flag Coverage Δ
unittests 89.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@tongyu-microsoft tongyu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What’s the issue here?

Signed-off-by: Ke Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants