Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exception in case categorical feature list doesn't have all string features #1720

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Sep 14, 2022

Description

All the rai insight components fail if any of the string features are not identified as categorical_features. This PR raises an UserConfigValidationException in such a scenario.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #1720 (cdafbd8) into main (d0f387f) will increase coverage by 3.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1720      +/-   ##
==========================================
+ Coverage   89.00%   92.10%   +3.09%     
==========================================
  Files         105       86      -19     
  Lines        5577     4268    -1309     
==========================================
- Hits         4964     3931    -1033     
+ Misses        613      337     -276     
Flag Coverage Δ
unittests 92.10% <100.00%> (+3.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sibleai/responsibleai/rai_insights/rai_insights.py 78.61% <100.00%> (+0.32%) ⬆️
raiwidgets/raiwidgets/dashboard.py
raiwidgets/raiwidgets/fairness_dashboard.py
raiwidgets/raiwidgets/__init__.py
raiwidgets/raiwidgets/interfaces.py
...iwidgets/raiwidgets/model_performance_dashboard.py
raiwidgets/raiwidgets/explanation_constants.py
raiwidgets/raiwidgets/explanation_dashboard.py
raiwidgets/raiwidgets/__version__.py
raiwidgets/raiwidgets/error_analysis_dashboard.py
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup enabled auto-merge (squash) September 19, 2022 16:47
@gaugup gaugup merged commit ac30fae into main Sep 19, 2022
@gaugup gaugup deleted the gaugup/RaiseExceptionCategoricalMismatch branch September 19, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants