Fix "Clear” button of Search field under 'Feature List' dialog is not Functional and Focus indicator is not visible on all four sides for “Tree map” and "heat map" tabs. #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: vinutha karanth <[email protected]>
vinuthakaranth
requested review from
romanlutz,
imatiach-msft,
xuke444,
tongyu-microsoft and
RubyZ10
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1718 +/- ##
=======================================
Coverage 89.00% 89.00%
=======================================
Files 105 105
Lines 5577 5577
=======================================
Hits 4964 4964
Misses 613 613
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: vinutha karanth <[email protected]>
1 similar comment
RubyZ10
reviewed
Sep 14, 2022
libs/error-analysis/src/lib/ErrorAnalysisDashboard/Controls/FeatureList/FeatureList.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: vinutha karanth <[email protected]>
…olbox into vikarant/FixClearSearchFieldBug
RubyZ10
approved these changes
Sep 14, 2022
…olbox into vikarant/FixClearSearchFieldBug
1 similar comment
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix:
[Functional -Azure Machine Learning - Feature List>Search box]: "Clear” button of Search field under 'Feature List' dialog is not Functional. - onsearch was being called with no params resulting in no action. Removing onclear worked.
[Usable - Azure Machine Learning - Model demo page>Error analysis]: Focus indicator is not visible on all four sides for “Tree map” and "heat map" tabs. - Since the above margin was consuming focus zone on adding margin to tabs, focus zone is visible. Similar design is present in Model overview component as well.
Checklist