Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct predict call to predict_proba #1717

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Sep 14, 2022

Description

It seems there was a miss from me in the PR #1702 where I cache the predict output in predict_proba_output variable. This PR corrects this miss and adds a test.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #1717 (958730a) into main (f6870ab) will increase coverage by 10.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #1717       +/-   ##
===========================================
+ Coverage   78.99%   89.00%   +10.01%     
===========================================
  Files          19      105       +86     
  Lines        1314     5577     +4263     
===========================================
+ Hits         1038     4964     +3926     
- Misses        276      613      +337     
Flag Coverage Δ
unittests 89.00% <100.00%> (+10.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sibleai/responsibleai/rai_insights/rai_insights.py 78.28% <100.00%> (ø)
...ai/responsibleai/_tools/counterfactual/__init__.py 100.00% <0.00%> (ø)
...core_flask/rai_core_flask/environments/__init__.py 100.00% <0.00%> (ø)
..._core_flask/rai_core_flask/environment_detector.py 53.33% <0.00%> (ø)
erroranalysis/erroranalysis/_internal/utils.py 84.61% <0.00%> (ø)
...onsibleai/responsibleai/serialization_utilities.py 96.55% <0.00%> (ø)
...is/erroranalysis/_internal/surrogate_error_tree.py 88.74% <0.00%> (ø)
responsibleai/responsibleai/_config/__init__.py 100.00% <0.00%> (ø)
erroranalysis/erroranalysis/version.py 100.00% <0.00%> (ø)
raiutils/raiutils/common/__init__.py 100.00% <0.00%> (ø)
... and 77 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup enabled auto-merge (squash) September 15, 2022 15:13
@gaugup gaugup merged commit 9f906b5 into main Sep 15, 2022
@gaugup gaugup deleted the gaugup/CorrectPredictProba branch September 15, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants