Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [Keyboard navigation - Azure Machine Learning - Model overview - Dataset cohorts]: Focus indicator is overlapping with the "help me choose metrics" button. #1716

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

vinuthakaranth
Copy link
Contributor

Signed-off-by: vinutha karanth [email protected]

Description

Fix [Keyboard navigation - Azure Machine Learning - Model overview - Dataset cohorts]: Focus indicator is overlapping with the "help me choose metrics" button.

Due to padding, focus zone was starting in padding zone. On updating to margin, focus zone was fixed.

HelpMeFocusZone

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes - NA
  • Documentation was updated if it was needed.

Signed-off-by: vinutha karanth <[email protected]>
@RubyZ10
Copy link
Contributor

RubyZ10 commented Sep 14, 2022

What does it look like in 320*256 resolution?

@vinuthakaranth
Copy link
Contributor Author

vinuthakaranth commented Sep 14, 2022

What does it look like in 320*256 resolution?
attaching screengif
HelpMeFocusZone320256

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #1716 (dde707e) into main (daa11c4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1716   +/-   ##
=======================================
  Coverage   89.00%   89.00%           
=======================================
  Files         105      105           
  Lines        5577     5577           
=======================================
  Hits         4964     4964           
  Misses        613      613           
Flag Coverage Δ
unittests 89.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vinuthakaranth vinuthakaranth enabled auto-merge (squash) September 14, 2022 19:14
@vinuthakaranth vinuthakaranth merged commit 40108ea into main Sep 14, 2022
@vinuthakaranth vinuthakaranth deleted the vikarant/FixAccessibilityBigs1 branch September 14, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants