Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility][Reflow] Individual conditional expectation plot #1699

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

RubyZ10
Copy link
Contributor

@RubyZ10 RubyZ10 commented Sep 9, 2022

Signed-off-by: Ruby Zhu [email protected]

Description

  1. Individual conditional expectation plot reflow
    image
    image
    image
    image

  2. minor error analysis tree - move the white rectangle background down a little bit
    Before change
    image
    After change
    image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Ruby Zhu <[email protected]>
Signed-off-by: Ruby Zhu <[email protected]>
@RubyZ10 RubyZ10 enabled auto-merge (squash) September 9, 2022 16:27
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

Merging #1699 (3496d36) into main (35747ad) will decrease coverage by 3.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1699      +/-   ##
==========================================
- Coverage   88.91%   85.37%   -3.55%     
==========================================
  Files         105       58      -47     
  Lines        5559     3036    -2523     
==========================================
- Hits         4943     2592    -2351     
+ Misses        616      444     -172     
Flag Coverage Δ
unittests 85.37% <ø> (-3.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../responsibleai/modelanalysis/constants/__init__.py
responsibleai/responsibleai/_config/__init__.py
...sponsibleai/responsibleai/managers/base_manager.py
...ai/responsibleai/_tools/error_analysis/__init__.py
...sibleai/responsibleai/rai_insights/rai_insights.py
...ponsibleai/responsibleai/_tools/causal/__init__.py
...ponsibleai/responsibleai/_tools/shared/versions.py
...tools/counterfactual/dashboard_schemas/__init__.py
...ibleai/_tools/causal/dashboard_schemas/__init__.py
.../databalanceanalysis/aggregate_balance_measures.py
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

1 similar comment
@RubyZ10 RubyZ10 merged commit 57dc02b into main Sep 9, 2022
@RubyZ10 RubyZ10 deleted the zhenzhu/A11y branch September 9, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants