refactor table view into data analysis component #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
tongyu-microsoft,
xuke444,
RubyZ10,
vinuthakaranth and
romanlutz
as code owners
imatiach-msft
force-pushed
the
ilmat/refactor-table-view
branch
from
35c2f1a to
3223359
Compare
Codecov Report
@@ Coverage Diff @@
## main #1673 +/- ##
=======================================
Coverage 88.88% 88.88%
=======================================
Files 105 105
Lines 5553 5553
=======================================
Hits 4936 4936
Misses 617 617
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1 similar comment
imatiach-msft
force-pushed
the
ilmat/refactor-table-view
branch
from
3223359 to
5878c35
Compare
imatiach-msft
force-pushed
the
ilmat/refactor-table-view
branch
3 times, most recently
from
cff7a21 to
d45ec44
Compare
2 similar comments
imatiach-msft
force-pushed
the
ilmat/refactor-table-view
branch
from
d45ec44 to
858e05a
Compare
RubyZ10
reviewed
Aug 31, 2022
RubyZ10
reviewed
Aug 31, 2022
RubyZ10
reviewed
Aug 31, 2022
RubyZ10
reviewed
Aug 31, 2022
RubyZ10
reviewed
Aug 31, 2022
RubyZ10
approved these changes
Aug 31, 2022
imatiach-msft
force-pushed
the
ilmat/refactor-table-view
branch
from
858e05a to
f950413
Compare
imatiach-msft
force-pushed
the
ilmat/refactor-table-view
branch
from
f950413 to
7a3beb9
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the table view into the data analysis component from the individual feature importances component.
Note there will be a follow-up PR to add a "mini-table" in the feature importances component to select a subset of indexes from the overall selected indexes in the tabular view. Also, we will still show the table by default if the dataset explorer component is missing in the follow-up PR.
New data analysis view with new "Table view" tab:
New individual feature importances tab:
Checklist