Vision dashboard backend without data characteristics tab #1668

jamesbchao · 2022-08-25T01:02:18Z

The vision dashboard backend without the data characteristics tab so as to make the PR smaller.
The backend functionality and additional fixups include:

display images from dataset passed into backend
compute single explanation on the fly with loading indicators for each image
image explorer view UI changes to make thumbnail size slider work
search functionality to filter by predicted or true labels
no data characteristics tab
no cohort functionality

Description

Checklist

I have added screenshots above for all UI changes.
I have added e2e tests for all UI changes.
Documentation was updated if it was needed.

codecov-commenter · 2022-08-25T01:06:11Z

Codecov Report

Merging #1668 (4452ff2) into main (77b295a) will decrease coverage by 0.16%.
The diff coverage is 47.61%.

❗ Current head 4452ff2 differs from pull request most recent head eae618b. Consider uploading reports for the commit eae618b to get more accurate results

@@            Coverage Diff             @@
##             main    #1668      +/-   ##
==========================================
- Coverage   89.04%   88.88%   -0.17%     
==========================================
  Files         105      105              
  Lines        5534     5553      +19     
==========================================
+ Hits         4928     4936       +8     
- Misses        606      617      +11

Flag	Coverage Δ
unittests	`88.88% <47.61%> (-0.17%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...idgets/raiwidgets/responsibleai_dashboard_input.py	`90.72% <10.00%> (-5.73%)`	⬇️
raiwidgets/raiwidgets/responsibleai_dashboard.py	`62.50% <50.00%> (-1.39%)`	⬇️
raiwidgets/raiwidgets/__version__.py	`100.00% <100.00%> (ø)`
responsibleai/responsibleai/__version__.py	`100.00% <100.00%> (ø)`
responsibleai/responsibleai/_interfaces.py	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-25T01:49:32Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/jbchao/vision-dashboard-backend-no-dc/dashboard/index.html

github-actions · 2022-08-25T02:01:39Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/jbchao/vision-dashboard-backend-no-dc/dashboard/index.html

github-actions · 2022-08-25T02:27:14Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/jbchao/vision-dashboard-backend-no-dc/dashboard/index.html

github-actions · 2022-08-25T23:13:17Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/jbchao/vision-dashboard-backend-no-dc/dashboard/index.html

github-actions · 2022-08-26T02:08:20Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/jbchao/vision-dashboard-backend-no-dc/dashboard/index.html

imatiach-msft · 2022-08-26T13:37:24Z

raiwidgets/raiwidgets/__version__.py

@@ -3,4 +3,4 @@

 # Version will be populated during release from version.cfg file
 # by running `yarn auto-version`
-version = "0.0.0"


this version is populated by the release script, so make sure to remove this when merging

it looks like you need to re-add back the 0.0.0

I fixed this for you and pushed to your PR

libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/Flyout.styles.ts

libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/ImageList.tsx

imatiach-msft · 2022-08-26T13:50:29Z

libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/ImageList.tsx

-    return ret;
+    if (itemIndex === 0) {
+      this.columnCount = Math.ceil(visibleRect.width / this.props.imageDim);
+      this.rowHeight = Math.floor(visibleRect.width / this.columnCount);


can visibleRect change from image to image? I'm wondering actually if these can all be variables on state.

I don't think it changes, but my movtivation behind not making columnCount and rowHeight state variables was to not trigger rerenders when they're calculated. Is it preferable to only use state variables?

libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/PageSizeSelectors.tsx

libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/TabsView.tsx

imatiach-msft · 2022-08-26T14:04:54Z

libs/model-assessment/src/lib/ModelAssessmentDashboard/Controls/TabsView/TabsView.tsx

+              {t.key === GlobalTabKeys.VisionTab &&
+                this.props.visionModelExplanationData && (
+                  <>
+                    <div className={classNames.sectionHeader}>


try to use Stack instead of div, like here

I was just copying all of the other components which use div and h3. Should I still use Stack even if all the other components aren't, or should I update them all to be Stacks?

Yes please use Stack wherever possible. The other components/examples are probably wrong if they use div. Stack is essentially div but with fluentui sprinkled in to fit our accessibility/style requirements. So please try to use Stack wherever possible instead of div.

imatiach-msft · 2022-08-26T14:05:37Z

raiwidgets/raiwidgets/__version__.py

@@ -3,4 +3,4 @@

 # Version will be populated during release from version.cfg file
 # by running `yarn auto-version`
-version = "0.0.0"


this version is populated by the release script, so make sure to remove this when merging

imatiach-msft · 2022-08-26T14:05:54Z

responsibleai/responsibleai/__version__.py

@@ -3,4 +3,4 @@

 # Version will be populated during release from version.cfg file
 # by running `yarn auto-version`
-version = "0.0.0"


oh it looks like this hasn't been resolved yet

I fixed this for you and pushed to your PR

github-actions · 2022-08-27T03:46:34Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/jbchao/vision-dashboard-backend-no-dc/dashboard/index.html

imatiach-msft

Looks great! Will merge this now that you've fixed all comments.

github-actions · 2022-08-29T05:47:05Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/jbchao/vision-dashboard-backend-no-dc/dashboard/index.html

jamesbchao requested review from imatiach-msft, tongyu-microsoft, xuke444, RubyZ10, vinuthakaranth, romanlutz, gaugup and kicha0 as code owners August 25, 2022 01:02

jamesbchao mentioned this pull request Aug 25, 2022

Vision dashboard backend with data characteristics #1669

Closed

3 tasks

jamesbchao force-pushed the jbchao/vision-dashboard-backend-no-dc branch 2 times, most recently from fdeba1e to dc3552b Compare August 25, 2022 01:43

jamesbchao force-pushed the jbchao/vision-dashboard-backend-no-dc branch from dc3552b to 4452ff2 Compare August 25, 2022 22:28

jamesbchao force-pushed the jbchao/vision-dashboard-backend-no-dc branch from 4452ff2 to e3819e0 Compare August 26, 2022 01:11

imatiach-msft reviewed Aug 26, 2022

View reviewed changes

imatiach-msft approved these changes Aug 26, 2022

View reviewed changes

jamesbchao force-pushed the jbchao/vision-dashboard-backend-no-dc branch from e3819e0 to 60024c2 Compare August 27, 2022 03:01

imatiach-msft approved these changes Aug 29, 2022

View reviewed changes

table view and initial flyout

eae618b

imatiach-msft force-pushed the jbchao/vision-dashboard-backend-no-dc branch from 60024c2 to eae618b Compare August 29, 2022 04:52

imatiach-msft merged commit f2c5bab into main Aug 29, 2022

imatiach-msft deleted the jbchao/vision-dashboard-backend-no-dc branch August 29, 2022 04:54

imatiach-msft mentioned this pull request Sep 12, 2022

release raiwidgets and responsibleai 0.22.0 #1707

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vision dashboard backend without data characteristics tab #1668

Vision dashboard backend without data characteristics tab #1668

jamesbchao commented Aug 25, 2022 •

edited

Loading

codecov-commenter commented Aug 25, 2022 •

edited

Loading

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 26, 2022

imatiach-msft Aug 26, 2022

imatiach-msft Aug 26, 2022

imatiach-msft Aug 29, 2022

imatiach-msft Aug 29, 2022

imatiach-msft Aug 26, 2022

jamesbchao Aug 27, 2022

imatiach-msft Aug 26, 2022

jamesbchao Aug 27, 2022 •

edited

Loading

imatiach-msft Aug 29, 2022

imatiach-msft Aug 26, 2022

imatiach-msft Aug 26, 2022

imatiach-msft Aug 29, 2022

imatiach-msft Aug 29, 2022

github-actions bot commented Aug 27, 2022

imatiach-msft left a comment

github-actions bot commented Aug 29, 2022

Vision dashboard backend without data characteristics tab #1668

Vision dashboard backend without data characteristics tab #1668

Conversation

jamesbchao commented Aug 25, 2022 • edited Loading

Description

Checklist

codecov-commenter commented Aug 25, 2022 • edited Loading

Codecov Report

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jamesbchao Aug 27, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 27, 2022

imatiach-msft left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 29, 2022

jamesbchao commented Aug 25, 2022 •

edited

Loading

codecov-commenter commented Aug 25, 2022 •

edited

Loading

jamesbchao Aug 27, 2022 •

edited

Loading