[Accessibility] Error analysis screen reader #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruby Zhu <[email protected]>
RubyZ10
requested review from
romanlutz,
imatiach-msft,
xuke444,
tongyu-microsoft and
vinuthakaranth
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1663 +/- ##
=======================================
Coverage 89.04% 89.04%
=======================================
Files 105 105
Lines 5534 5534
=======================================
Hits 4928 4928
Misses 606 606
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1 similar comment
libs/error-analysis/src/lib/ErrorAnalysisDashboard/Controls/TreeViewRenderer/TreeViewUtils.ts
Outdated
Show resolved
Hide resolved
libs/error-analysis/src/lib/ErrorAnalysisDashboard/Controls/TreeViewRenderer/TreeViewUtils.ts
Show resolved
Hide resolved
imatiach-msft
approved these changes
Aug 23, 2022
Signed-off-by: Ruby Zhu <[email protected]>
1 similar comment
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruby Zhu [email protected]
Description
This PR add screen reader description for the error analysis tree
when coming to the error analysi tree, screen reader will read "interactive chart".
when traversing each tree node, screen reader will read the condition and tooltip content, for example, in below screen shot for the selected node, screen reader will announce:
marital-status == Married-civ-spouse Correct (#): 9 Incorrect (#): 17 Error coverage 94.44% Error rate 65.38 %
For disabled view, screen reader will announce the text on the node
Checklist