Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable validations for FeatureMetadata when passed into RAIInsights #1651

Merged
merged 4 commits into from
Aug 20, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 18, 2022

Description

It seems like the validation was happening in the function _validate_rai_insights_input_parameters but the feature_metadata was not passed to the function. Now passing this parameter and added a test.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Merging #1651 (195be27) into main (b899faf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1651   +/-   ##
=======================================
  Coverage   90.20%   90.20%           
=======================================
  Files          39       39           
  Lines        1716     1716           
=======================================
  Hits         1548     1548           
  Misses        168      168           
Flag Coverage Δ
unittests 90.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup enabled auto-merge (squash) August 19, 2022 18:06
@gaugup gaugup merged commit 14f9562 into main Aug 20, 2022
@gaugup gaugup deleted the gaugup/AddMissingValidationFeatureMetadata branch August 20, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants