[Accessibility] Error analysis tree node change 1. Bubble error rate colors; 2. Bubble text & fill #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruby Zhu <[email protected]>
Signed-off-by: Ruby Zhu <[email protected]>
RubyZ10
requested review from
romanlutz,
xuke444,
tongyu-microsoft,
vinuthakaranth and
imatiach-msft
as code owners
RubyZ10
commented
Aug 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #1649 +/- ##
==========================================
- Coverage 89.00% 85.61% -3.39%
==========================================
Files 105 58 -47
Lines 5529 3017 -2512
==========================================
- Hits 4921 2583 -2338
+ Misses 608 434 -174
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tongyu-microsoft
approved these changes
Aug 17, 2022
libs/error-analysis/src/lib/ErrorAnalysisDashboard/Controls/TreeViewRenderer/TreeViewUtils.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I created a chat to discuss this. I do think it might be more difficult to understand the tree in the case the error rates are all within a band, say the 75-100 percent error rate band - all of the nodes will be the exact same color then. I think this might need a bit more discussion, as there are some scenarios where the new UI look might become more confusing.
1 similar comment
Signed-off-by: Ruby Zhu <[email protected]>
Signed-off-by: Ruby Zhu <[email protected]>
imatiach-msft
approved these changes
Aug 18, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes two changes:
Before change:
After change:
Checklist