Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for uncovered condition in responsibleai_dashboard_input.py #1638

Merged
merged 3 commits into from
Aug 16, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 15, 2022

Description

Add test for scenario when either of the features could be "None" when querying matrix filter end point.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2022

Codecov Report

Merging #1638 (4f4aecd) into main (05f3784) will decrease coverage by 2.94%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1638      +/-   ##
==========================================
- Coverage   91.97%   89.03%   -2.95%     
==========================================
  Files          86      105      +19     
  Lines        4188     5489    +1301     
==========================================
+ Hits         3852     4887    +1035     
- Misses        336      602     +266     
Flag Coverage Δ
unittests 89.03% <ø> (-2.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raiwidgets/raiwidgets/error_handling.py 100.00% <0.00%> (ø)
raiwidgets/raiwidgets/cohort.py 95.00% <0.00%> (ø)
...dgets/raiwidgets/error_analysis_dashboard_input.py 66.09% <0.00%> (ø)
raiwidgets/raiwidgets/explanation_dashboard.py 83.33% <0.00%> (ø)
raiwidgets/raiwidgets/interfaces.py 100.00% <0.00%> (ø)
raiwidgets/raiwidgets/fairness_dashboard.py 19.56% <0.00%> (ø)
raiwidgets/raiwidgets/error_analysis_dashboard.py 72.41% <0.00%> (ø)
raiwidgets/raiwidgets/model_analysis_dashboard.py 100.00% <0.00%> (ø)
...iwidgets/raiwidgets/model_performance_dashboard.py 50.00% <0.00%> (ø)
...idgets/raiwidgets/responsibleai_dashboard_input.py 96.45% <0.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

1 similar comment
@gaugup gaugup enabled auto-merge (squash) August 16, 2022 19:14
@gaugup gaugup merged commit aadfa3c into main Aug 16, 2022
@gaugup gaugup deleted the gaugup/AddTestForUncoveredCondition branch August 16, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants