[300 line limit] Refactor CounterfactualChart #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tongyu-microsoft
requested review from
romanlutz,
vinuthakaranth,
xuke444 and
RubyZ10
as code owners
tongyu-microsoft
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1624 +/- ##
=======================================
Coverage 88.86% 88.86%
=======================================
Files 105 105
Lines 5449 5449
=======================================
Hits 4842 4842
Misses 607 607
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1 similar comment
imatiach-msft
approved these changes
Aug 10, 2022
vinuthakaranth
approved these changes
Aug 10, 2022
…ft/responsible-ai-widgets into tongy/limit300linesPart4
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors CounterfactualChart, so line of code for CounterfactualChart is reduced from 938 lines to 249 lines.
Description
For CounterfactualList.tsx, this PR creates a few new components as children of CounterfactualList component. So each file now has less than 300 lines of code.
This PR basically does the following:
1.Every new CounterfactualXXX components in the PR is originally from CounterfactualChart
2. Rename CounterfactualChart to CounterfactualComponent, as it does include CounterfactualChart, LocalImportanceChart and error dialog etc -> so CounterfactualComponent is the parent component in my PR.
3. CounterfactualComponent is parent of CounterfactualChartWithLegend, CounterfactualLocalImportanceChart and CounterfactualErrorDialog
4. CounterfactualChartWithLegend is parent of CounterfactualChart and CounterfactualChartLegend
5. Moved all getXXX functions which doesn't contain any setState in the function, to src/util folder.
Checklist