Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CalculateBoxPlot.test.tsx to core-ui #1620

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 5, 2022

Description

Seems like current location of the test file is misplaced. Running the tests in CalculateBoxPlot.test.tsx doesn't contribute to code in calculateBoxData.ts. Hence, moving this file to core-ui.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2022

Codecov Report

Merging #1620 (402dd5e) into main (57884c5) will increase coverage by 3.64%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1620      +/-   ##
==========================================
+ Coverage   85.25%   88.90%   +3.64%     
==========================================
  Files          58      111      +53     
  Lines        2937     5470    +2533     
==========================================
+ Hits         2504     4863    +2359     
- Misses        433      607     +174     
Flag Coverage Δ
unittests 88.90% <ø> (+3.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
responsibleai/responsibleai/_config/base_config.py 92.30% <0.00%> (ø)
...ai/responsibleai/_tools/counterfactual/__init__.py 100.00% <0.00%> (ø)
...ai/responsibleai/rai_insights/rai_base_insights.py 87.58% <0.00%> (ø)
...bleai/responsibleai/_tools/causal/causal_result.py 97.05% <0.00%> (ø)
...ponsibleai/responsibleai/_tools/causal/__init__.py 100.00% <0.00%> (ø)
...ai/responsibleai/_tools/causal/causal_constants.py 100.00% <0.00%> (ø)
responsibleai/responsibleai/_config/__init__.py 100.00% <0.00%> (ø)
responsibleai/responsibleai/_internal/constants.py 100.00% <0.00%> (ø)
...ponsibleai/responsibleai/rai_insights/constants.py 100.00% <0.00%> (ø)
...ibleai/_tools/causal/dashboard_schemas/__init__.py 100.00% <0.00%> (ø)
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@gaugup gaugup enabled auto-merge (squash) August 9, 2022 01:11
@gaugup gaugup merged commit c98a1d8 into main Aug 9, 2022
@gaugup gaugup deleted the gaugup/MoveUIBoxPlotTests branch August 9, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants