Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cohort filtering capability in RAIInsights class #1618

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 5, 2022

Description

This PR add the function get_filtered_test_data() which takes in cohort filters and returns back the filtered dataset. The implementation of the function get_filtered_test_data is based on calling the relevant filtering methods from the class FilterDataWithCohortFilters within error analysis.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2022

Codecov Report

Merging #1618 (6a869e8) into main (b49b089) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1618      +/-   ##
==========================================
+ Coverage   88.96%   88.97%   +0.01%     
==========================================
  Files         111      111              
  Lines        5448     5453       +5     
==========================================
+ Hits         4847     4852       +5     
  Misses        601      601              
Flag Coverage Δ
unittests 88.97% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sibleai/responsibleai/rai_insights/rai_insights.py 76.81% <100.00%> (+0.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup enabled auto-merge (squash) August 8, 2022 18:12
@gaugup gaugup merged commit 46e04a0 into main Aug 8, 2022
@gaugup gaugup deleted the gaugup/AddCohortFilteringRAIInsights branch August 8, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants