Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature metadata to IDataset and JointDataset #1614

Merged
merged 4 commits into from
Aug 9, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 4, 2022

Description

This change add the FeatureMetaData to IDataset and JointDataset. This is the foundation work for adding feature metadata for UI and will be followed by integration of identity feature into feature importance, counterfactual and causal scatter plots. Also, included is the unit test for the JointDataset class for this change.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #1614 (99ec96f) into main (4c4365a) will decrease coverage by 3.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1614      +/-   ##
==========================================
- Coverage   88.86%   85.25%   -3.61%     
==========================================
  Files         105       58      -47     
  Lines        5449     2937    -2512     
==========================================
- Hits         4842     2504    -2338     
+ Misses        607      433     -174     
Flag Coverage Δ
unittests 85.25% <ø> (-3.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...i/responsibleai/managers/error_analysis_manager.py
responsibleai/responsibleai/_internal/constants.py
...tabalanceanalysis/distribution_balance_measures.py
responsibleai/responsibleai/__version__.py
...eai/responsibleai/managers/data_balance_manager.py
...tools/error_analysis/dashboard_schemas/__init__.py
...onsibleai/responsibleai/serialization_utilities.py
responsibleai/responsibleai/_interfaces.py
...ponsibleai/responsibleai/modelanalysis/__init__.py
responsibleai/responsibleai/__init__.py
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vinuthakaranth
Copy link
Contributor

vinuthakaranth commented Aug 4, 2022

Thanks for adding unit tests! Appreciate it!

Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
@gaugup gaugup enabled auto-merge (squash) August 9, 2022 15:09
@gaugup gaugup merged commit c5d7319 into main Aug 9, 2022
@gaugup gaugup deleted the gaugup/UIChangeFeatureMetadata branch August 9, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants