Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to RAI text dashboard - update test app values to latest shap release, fix predicted label, limit selection to one row, fix random crash #1605

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

imatiach-msft
Copy link
Contributor

Description

This PR includes several small updates and bug fixes to the RAI text dashboard after manual testing:
1.) Update the predicted probabilities and local feature importance values to the latest shap package version update in the test app (which also changed the predicted values to be probabilities instead of raw values).
2.) Fix predicted label being incorrectly shown as the lowest instead of highest probability label.
image
3.) Limit selection of instances to a single instance in text case, unlike tabular case which has comparisons enabled.
4.) Fix random crash due to text and importances length getting out of sync in intermediate render calls when clicking on different rows to view different local importances

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

… release, fix predicted label, limit selection to one row, fix random crash
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #1605 (d0c4582) into main (371e669) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1605   +/-   ##
=======================================
  Coverage   88.91%   88.91%           
=======================================
  Files         110      110           
  Lines        5415     5415           
=======================================
  Hits         4815     4815           
  Misses        600      600           
Flag Coverage Δ
unittests 88.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imatiach-msft imatiach-msft merged commit 9332c03 into main Aug 3, 2022
@imatiach-msft imatiach-msft deleted the ilmat/text-bug-fixes branch August 3, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants