Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor categorical statistics computation in separate module #1600

Merged
merged 4 commits into from
Aug 3, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 2, 2022

Description

Refactored the categorical stats computation logic into its own module in error analysis so that RAIInsights can leverage the same.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #1600 (e039b45) into main (d8b1f9e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1600      +/-   ##
==========================================
+ Coverage   88.89%   88.91%   +0.02%     
==========================================
  Files         109      110       +1     
  Lines        5402     5415      +13     
==========================================
+ Hits         4802     4815      +13     
  Misses        600      600              
Flag Coverage Δ
unittests 88.91% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...is/erroranalysis/_internal/process_categoricals.py 100.00% <100.00%> (ø)
...ranalysis/erroranalysis/analyzer/error_analyzer.py 92.50% <100.00%> (-0.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup enabled auto-merge (squash) August 2, 2022 23:12
@gaugup gaugup merged commit 1411011 into main Aug 3, 2022
@gaugup gaugup deleted the gaugup/ProcessCategoricals branch August 3, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants