Fix tooltip location showing up incorrectly due to conflicting ids #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
force-pushed
the
ilmat/fix-tooltip-location
branch
from
8ec0f9c to
5597d03
Compare
1 similar comment
|
Can you add the output after your fix? |
gaugup
approved these changes
Aug 2, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When clicking info icon in the local importances plot, the tooltip shows up in the wrong location due to duplicate ids "cross-class-weight-info" in the code. That id in the LabelWithCallout component seems to actually be inconsistent with what the component does, so I assume it was a copy-paste error. Giving the component a different id resolved the issue.
Before fix:
After fix:
Checklist