Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests in test_responsibleai_dashboard_input.py to have common success and failure criteria #1591

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Jul 28, 2022

Description

It seems lot of these were repeated assert patterns. Refactored the success and failure criteria into a separate base class to use it across multiple tests later.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

…n success and failure criteria

Signed-off-by: Gaurav Gupta <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #1591 (fe6d576) into main (ce77a5d) will decrease coverage by 0.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1591      +/-   ##
==========================================
- Coverage   89.63%   88.95%   -0.68%     
==========================================
  Files          99      109      +10     
  Lines        5121     5379     +258     
==========================================
+ Hits         4590     4785     +195     
- Misses        531      594      +63     
Flag Coverage Δ
unittests 88.95% <ø> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rai_core_flask/rai_core_flask/__init__.py 100.00% <0.00%> (ø)
...re_flask/environments/local_ipython_environment.py 88.88% <0.00%> (ø)
...core_flask/rai_core_flask/environments/__init__.py 100.00% <0.00%> (ø)
..._core_flask/rai_core_flask/environment_detector.py 53.33% <0.00%> (ø)
rai_core_flask/rai_core_flask/flask_helper.py 92.30% <0.00%> (ø)
...i_core_flask/environments/public_vm_environment.py 88.88% <0.00%> (ø)
...ai_core_flask/environments/azure_nb_environment.py 73.52% <0.00%> (ø)
..._flask/environments/credentialed_vm_environment.py 100.00% <0.00%> (ø)
...sk/rai_core_flask/environments/base_environment.py 57.14% <0.00%> (ø)
..._core_flask/environments/databricks_environment.py 56.25% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce77a5d...fe6d576. Read the comment docs.

@gaugup gaugup enabled auto-merge (squash) July 29, 2022 16:48
@gaugup gaugup merged commit 5f322db into main Jul 29, 2022
@gaugup gaugup deleted the gaugup/RefactorTestCriteriaTests branch July 29, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants