Vision explanation dashboard -- Image explorer view #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbchao
requested review from
xuke444,
vinuthakaranth and
romanlutz
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1587 +/- ##
=======================================
Coverage 88.89% 88.89%
=======================================
Files 109 109
Lines 5402 5402
=======================================
Hits 4802 4802
Misses 600 600
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jamesbchao
force-pushed
the
jbchao/vision-dashboard-image-list
branch
from
1a0f02c to
ea106b6
Compare
2 tasks
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/ImageList.tsx
Outdated
Show resolved
Hide resolved
imatiach-msft
approved these changes
Jul 29, 2022
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/ImageList.tsx
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/ImageList.tsx
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/TitleBar.styles.ts
Outdated
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/TitleBar.tsx
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/TitleBar.tsx
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboardStyles.ts
Outdated
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboard.tsx
Outdated
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboardStyles.ts
Outdated
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboardStyles.ts
Outdated
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/ImageList.tsx
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboard.tsx
Outdated
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboard.tsx
Outdated
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboard.tsx
Outdated
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboard.tsx
Outdated
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboard.tsx
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboard.tsx
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboardStyles.ts
Outdated
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboardStyles.ts
Outdated
Show resolved
Hide resolved
jamesbchao
force-pushed
the
jbchao/vision-dashboard-image-list
branch
from
9a4e023 to
0c3624c
Compare
jamesbchao
force-pushed
the
jbchao/vision-dashboard-image-list
branch
from
df3ffda to
ca7ad0a
Compare
1 similar comment
vinuthakaranth
approved these changes
Aug 2, 2022
| top: "2px" | ||
| }, | ||
| successIcon: { | ||
| color: "#107c10", |
There was a problem hiding this comment.
I might have missed, will you be using semantic colors in all places in coming PRs?
There was a problem hiding this comment.
Sorry, what are semantic colors? I just copied and pasted the values from the Fluent UI theme colors docs, but I can change it to use the get theme stuff too if that's preferred.
There was a problem hiding this comment.
yes you need to use the theme stuff, not specific values
There was a problem hiding this comment.
you can update in separate PR too I think, that's ok
|
merged PR on @jamesbchao 's behalf - please update colors to be semantic though for that last comment in separate PR |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The image explorer view frontend. Limited functionality including resizing images and switching tabs. Panel/flyout functionality and other tabs will be included in subsequent PRs once this one is merged.
Checklist