Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backend functions in causal_manager.py to handle dashboard requests #1579

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Jul 24, 2022

Description

This PR adds request_global_cohort_effects, request_local_instance_effects and request_global_cohort_policy to causal_manager.py. These functions are added so that the python backend (responsibleai) can request global cohort level stats for causal effects and causal policy.

The related PR is #1552, which requires additional work to add the cohort level filtering to RAIdashboard endpoints.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2022

Codecov Report

Merging #1579 (4aea12e) into main (f8312f6) will increase coverage by 0.07%.
The diff coverage is 96.22%.

@@            Coverage Diff             @@
##             main    #1579      +/-   ##
==========================================
+ Coverage   88.87%   88.95%   +0.07%     
==========================================
  Files         109      109              
  Lines        5332     5379      +47     
==========================================
+ Hits         4739     4785      +46     
- Misses        593      594       +1     
Flag Coverage Δ
unittests 88.95% <96.22%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onsibleai/responsibleai/managers/causal_manager.py 95.36% <95.65%> (-0.06%) ⬇️
...bleai/responsibleai/_tools/causal/causal_result.py 97.05% <96.66%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8312f6...4aea12e. Read the comment docs.

Signed-off-by: Gaurav Gupta <[email protected]>
@gaugup gaugup enabled auto-merge (squash) July 27, 2022 16:15
@gaugup gaugup merged commit fcdf459 into main Jul 27, 2022
@gaugup gaugup deleted the gaugup/CausalBackendRequestFunctions branch July 27, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants