Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strict pinnings from rai-core-flask requirements.txt. #1578

Merged

Conversation

janjagusch
Copy link
Contributor

Hi!

We're working on making the responsible-ai-toolbox available on conda-forge. We've noticed that the rai-core-flask package has very strict pinnings in its install_requires, making it difficult to install it with other packages in the same environment. This is because the contents of the requirements.txt file are used to set the install_requires section in the setup.py.

In this PR, we propose removing the strict pinnings (replacing == with <= or >=). We adjusted the pinnings to the best of our knowledge. Still, some changes might be incorrect, so please review this carefully.

If you agree with the proposed changes, it would be much appreciated if you could release of new version of rai-core-flask, so we can also loosen the strict pinnings in the conda-forge feedstock.

Thanks a lot for your help! 🙏

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2022

Codecov Report

Merging #1578 (c13849c) into main (e3d0f24) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1578   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files         109      109           
  Lines        5295     5295           
=======================================
  Hits         4662     4662           
  Misses        633      633           
Flag Coverage Δ
unittests 88.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d0f24...c13849c. Read the comment docs.

@janjagusch
Copy link
Contributor Author

janjagusch commented Jul 23, 2022

I'm pretty sure the CI failure is unrelated to my changes and most likely due to a missing secret in my fork:

There are no credentials provided in your command and environment, we will query for the account key inside your storage account.

@imatiach-msft
Copy link
Contributor

merging this PR on behalf of submitter since I don't see any objections to this PR

@imatiach-msft imatiach-msft merged commit e046f0b into microsoft:main Jul 28, 2022
@imatiach-msft
Copy link
Contributor

"If you agree with the proposed changes, it would be much appreciated if you could release of new version of rai-core-flask, so we can also loosen the strict pinnings in the conda-forge feedstock."
Sounds like I need to create a PR to do a version bump of rai-core-flask and then do a release to pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants