Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant lines of code in StatisticsUtils.ts #1571

Merged
merged 4 commits into from
Jul 22, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Jul 21, 2022

Description

It seems like the following lines are duplicated:-

    {
      key: BinaryClassificationMetrics.F1Score,
      label: localization.Interpret.Statistics.f1Score,
      stat:
        truePosCount / (truePosCount + 0.5 * (falsePosCount + falseNegCount))
    },

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@gaugup gaugup requested a review from imatiach-msft July 21, 2022 06:06
@gaugup gaugup enabled auto-merge (squash) July 21, 2022 19:59
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #1571 (067b620) into main (4e97f7f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1571   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files         109      109           
  Lines        5291     5291           
=======================================
  Hits         4658     4658           
  Misses        633      633           
Flag Coverage Δ
unittests 88.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e97f7f...067b620. Read the comment docs.

@gaugup gaugup merged commit fcc7530 into main Jul 22, 2022
@gaugup gaugup deleted the gaugup/RemoveRedudantCode branch July 22, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants