-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hierarchy to rai exceptions #1568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1568 +/- ##
==========================================
+ Coverage 85.12% 88.04% +2.92%
==========================================
Files 57 109 +52
Lines 2877 5295 +2418
==========================================
+ Hits 2449 4662 +2213
- Misses 428 633 +205
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
imatiach-msft
approved these changes
Jul 20, 2022
vinuthakaranth
approved these changes
Jul 21, 2022
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are broadly two kinds of the errors that could happen in the
responsibleai
system. One set of error can be caused by bad inputs from the users which we could classify asUser Errors
. The second set of errors could happen due to error conditions in theresponsibleai
system which could mean that we halt the execution. These could be classified asSystem Errors
. Ideal goal of our product should to minimize systems errors and be able to progressively capture cases where users can run into errors with the system,This PR defines two base exceptions for
UserErrorException
andSystemErrorException
and inherits the child exception classes, likeDuplicateManagerConfigException
, from the above two classes. This could in future help us identify the user errors and systems errors clearly and help us narrow down the system errors.Checklist