Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hierarchy to rai exceptions #1568

Merged
merged 6 commits into from
Jul 22, 2022
Merged

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Jul 20, 2022

Description

There are broadly two kinds of the errors that could happen in the responsibleai system. One set of error can be caused by bad inputs from the users which we could classify as User Errors. The second set of errors could happen due to error conditions in the responsibleai system which could mean that we halt the execution. These could be classified as System Errors. Ideal goal of our product should to minimize systems errors and be able to progressively capture cases where users can run into errors with the system,

This PR defines two base exceptions for UserErrorException and SystemErrorException and inherits the child exception classes, like DuplicateManagerConfigException, from the above two classes. This could in future help us identify the user errors and systems errors clearly and help us narrow down the system errors.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022

Codecov Report

Merging #1568 (75570a8) into main (f34a2e9) will increase coverage by 2.92%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1568      +/-   ##
==========================================
+ Coverage   85.12%   88.04%   +2.92%     
==========================================
  Files          57      109      +52     
  Lines        2877     5295    +2418     
==========================================
+ Hits         2449     4662    +2213     
- Misses        428      633     +205     
Flag Coverage Δ
unittests 88.04% <100.00%> (+2.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
responsibleai/responsibleai/exceptions.py 100.00% <100.00%> (ø)
...leai/responsibleai/databalanceanalysis/__init__.py 100.00% <0.00%> (ø)
responsibleai/responsibleai/_config/base_config.py 92.30% <0.00%> (ø)
...tabalanceanalysis/distribution_balance_measures.py 100.00% <0.00%> (ø)
...onsibleai/responsibleai/serialization_utilities.py 96.55% <0.00%> (ø)
...eai/responsibleai/managers/data_balance_manager.py 96.00% <0.00%> (ø)
responsibleai/responsibleai/__init__.py 100.00% <0.00%> (ø)
...ponsibleai/responsibleai/modelanalysis/__init__.py 100.00% <0.00%> (ø)
...ai/databalanceanalysis/feature_balance_measures.py 100.00% <0.00%> (ø)
...bleai/responsibleai/_tools/causal/causal_config.py 100.00% <0.00%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f34a2e9...75570a8. Read the comment docs.

@gaugup gaugup changed the title [WIP] Add hierarchy to rai exceptions Add hierarchy to rai exceptions Jul 20, 2022
@gaugup gaugup enabled auto-merge (squash) July 22, 2022 18:10
1 similar comment
@gaugup gaugup merged commit d4c2d4e into main Jul 22, 2022
@gaugup gaugup deleted the gaugup/AddHierarchyToRAIExceptions branch July 22, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants