fix erroranalysis erroring on serialization with numpy int64 feature names #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
force-pushed
the
ilmat/fix-ea-int64-feat-names
branch
2 times, most recently
from
431affb to
df55da2
Compare
Codecov Report
@@ Coverage Diff @@
## main #1537 +/- ##
==========================================
+ Coverage 87.34% 87.41% +0.07%
==========================================
Files 108 108
Lines 5103 5101 -2
==========================================
+ Hits 4457 4459 +2
+ Misses 646 642 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
2 similar comments
xuke444
approved these changes
Jul 6, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During benchmarking, we discovered that datasets which had indexes for feature names - specifically numpy int64 values - would cause erroranalysis ErrorReports to fail to serialize.
Checklist